From: Florian Müllner Date: Sat, 28 Mar 2020 17:55:17 +0000 (+0100) Subject: shellDBus: Return error from ReloadExtension X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~751^2^2~14 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f3fcc4adb7ccdb61d88dba64a2d74d8a95088a13;p=gnome-shell.git shellDBus: Return error from ReloadExtension The method has been deprecated because it generally doesn't (and can't) work. Clarify that by returning an error instead of apparently doing nothing. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2510 --- diff --git a/js/ui/shellDBus.js b/js/ui/shellDBus.js index 2b6b2ae96..f64081b24 100644 --- a/js/ui/shellDBus.js +++ b/js/ui/shellDBus.js @@ -329,12 +329,11 @@ var GnomeShellExtensions = class { (conn, res) => conn.call_finish(res)); } - ReloadExtension(uuid) { - let extension = Main.extensionManager.lookup(uuid); - if (!extension) - return; - - Main.extensionManager.reloadExtension(extension); + ReloadExtensionAsync(params, invocation) { + invocation.return_error_literal( + Gio.DBusError, + Gio.DBusError.NOT_SUPPORTED, + 'ReloadExtension is deprecated and does not work'); } CheckForUpdates() {